Fixed verification ordering priority and speedup #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
added
area: performance
…fyImplementationRunning
|
Niiice! I did make a few changes, hope that's OK. I've changed the verification ordering tests so they test against the API instead of internals, and I made two refactorings. |
keyboardDrummer
previously approved these changes
Jul 4, 2022
…-lang/dafny into fix-verification-ordering-priority
keyboardDrummer
previously approved these changes
Jul 5, 2022
…-lang/dafny into fix-verification-ordering-priority
…-lang/dafny into fix-verification-ordering-priority
| }); | ||
| } | ||
|
|
||
| private Position GetPositionOf(string code, string symbol) { |
There was a problem hiding this comment.
Funny would be if we could use LSP's workspace symbol feature to ask for the positions ^^
keyboardDrummer
previously approved these changes
Jul 5, 2022
Closed
… not done at about the same time
MikaelMayer
commented
Jul 7, 2022
Source/DafnyLanguageServer.Test/GutterStatus/ReorderingVerificationGutterStatusTester.cs
Outdated
Show resolved
Hide resolved
Source/DafnyLanguageServer.Test/GutterStatus/ReorderingVerificationGutterStatusTester.cs
Outdated
Show resolved
Hide resolved
keyboardDrummer
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2347
Also fixes the number of cores to the engine option which was never set, so it defaulted to 1.
Before this PR, on an 8-core machine with vscore set to 8 in VSCode:
After this PR, same machine, same options
Note the small grey bar where it should be green. This is a video encoding issue.
Can you spot the 4 differences?
I did not write tests for verifying ordering as I found such tests used to be unstable and randomly crash the CI. I only did unit testing to verify that the priority is correctly assigned, but that PR fixes the fact that priority setting was done after verification was launched, which was useless.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.