Do not kill LSP server process when exception occurs in doc change handler, and prevent out of range exception #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
reviewed
Aug 31, 2022
| message = "Related location (could not read file " + fileName + ")"; | ||
| } | ||
| var content = File.ReadAllText(fileName); | ||
| message = FormatRelated(content.Substring(range.StartToken.pos, rangeLength)); |
There was a problem hiding this comment.
I guess trading the previously optimized code for this simple but costly one is worth the fact that we don't need to deal with encodings. That's fair.
There was a problem hiding this comment.
I think all included files should be loaded into memory and available through some in memory filesystem, so then there wouldn't be any file read here. The file read here seems like it might significantly effect performance, but at least it's better than the crash.
Co-authored-by: Mikaël Mayer <MikaelMayer@users.noreply.github.com>
Co-authored-by: Mikaël Mayer <MikaelMayer@users.noreply.github.com>
…into textFromOtherFile
RustanLeino
previously approved these changes
Aug 31, 2022
atomb
previously approved these changes
Aug 31, 2022
keyboardDrummer
dismissed stale reviews from atomb and RustanLeino
via
3be43de
fabiomadge
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Manual testing with VSCode
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.