Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable new style options in the :options attribute #3252

Merged
merged 4 commits into from
Dec 22, 2022
Merged

Enable new style options in the :options attribute #3252

merged 4 commits into from
Dec 22, 2022

Conversation

keyboardDrummer
Copy link
Member

Fixes #3245

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer enabled auto-merge (squash) December 22, 2022 12:35
davidcok
davidcok approved these changes Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@davidcok davidcok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but question: is it right that this just added support for --function-syntax and --quantifier-syntax? Shouldn't other new options also be supported? Or is :options that limited in what options it admits?

@keyboardDrummer keyboardDrummer merged commit 48b01e2 into dafny-lang:master Dec 22, 2022
@keyboardDrummer
Copy link
Member Author

keyboardDrummer commented Dec 22, 2022 •
edited

Approved but question: is it right that this just added support for --function-syntax and --quantifier-syntax? Shouldn't other new options also be supported? Or is :options that limited in what options it admits?

Supported for configuration through module attributes must be added through extra code, and currently only those two are supported, both using the new and the old syntax.

@keyboardDrummer keyboardDrummer deleted the newStyleOptionsAttribute branch December 22, 2022 13:59
RustanLeino pushed a commit to RustanLeino/dafny that referenced this pull request Dec 29, 2022
@keyboardDrummer @RustanLeino
Enable new style options in the :options attribute (dafny-lang#3252)
cb95beb 
Fixes dafny-lang#3245

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcok davidcok davidcok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New-style options are not supported in the :options attribute
2 participants
@keyboardDrummer @davidcok