Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating :heapQuantifier; small documentation tasks #3456

Merged
merged 213 commits into from
Feb 10, 2023

Conversation

davidcok
Copy link
Collaborator

@davidcok davidcok commented Feb 4, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

davidcok and others added 30 commits January 29, 2021 12:41
Copy link
Collaborator

@RustanLeino RustanLeino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on many coding style and code font issues, but I may have missed some. Also, I'm suggest renaming some of the identifiers--it's nice if the actuals have different names from the formals, but since the current names of the actuals would be hard to understand without more context, I suggest simplifying them to other, plausible names.

docs/DafnyRef/Statements.md Outdated Show resolved Hide resolved
docs/HowToFAQ/FAQMapExtensionality.md Outdated Show resolved Hide resolved
docs/HowToFAQ/FAQMapExtensionality.md Outdated Show resolved Hide resolved
docs/HowToFAQ/FAQMapExtensionality.md Outdated Show resolved Hide resolved
docs/HowToFAQ/FAQMapExtensionality.md Outdated Show resolved Hide resolved
docs/HowToFAQ/FAQMapExtensionality.md Outdated Show resolved Hide resolved
docs/HowToFAQ/FAQMapExtensionality.md Outdated Show resolved Hide resolved
docs/HowToFAQ/FAQMapExtensionality.md Outdated Show resolved Hide resolved
@@ -61,7 +62,7 @@ There are also publications and lecture notes:
* Videos at [Verification Corner](https://www.youtube.com/channel/UCP2eLEql4tROYmIYm5mA27A)

And some books:
* K. Rustan M. Leino, 2023, [_Program Proofs_](https://mitpress.mit.edu/9780262546232/program-proofs/), to be available in 2023.
* K. Rustan M. Leino, 2023, [_Program Proofs_](https://mitpress.mit.edu/9780262546232/program-proofs/), available March, 2023.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the subsequent line, I suggest either removing the bullet about the draft version from Lulu or stating that it is available only until the MIT Press version comes out.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified but left in, just until the book is for sure available.

Comment on lines 113 to 114
Being “injective” is the mathematical description of any function f that satisfies the property you’re giving in the precondition.
Another name for “injective” is “one-to-one” (which sounds more symmetric than it is--hence, the name “injective” is probably better).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's any reason to mention "injectivity" and "one-to-one" in this answer, since the question and the rest of the answer don't make use of these definitions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

davidcok and others added 11 commits February 8, 2023 17:55
Co-authored-by: Rustan Leino <leino@amazon.com>
Co-authored-by: Rustan Leino <leino@amazon.com>
Co-authored-by: Rustan Leino <leino@amazon.com>
Co-authored-by: Rustan Leino <leino@amazon.com>
Co-authored-by: Rustan Leino <leino@amazon.com>
Co-authored-by: Rustan Leino <leino@amazon.com>
Co-authored-by: Rustan Leino <leino@amazon.com>
Co-authored-by: Rustan Leino <leino@amazon.com>
@davidcok davidcok enabled auto-merge (squash) February 9, 2023 17:45
davidcok and others added 7 commits February 9, 2023 15:51
Co-authored-by: Rustan Leino <leino@amazon.com>
Co-authored-by: Rustan Leino <leino@amazon.com>
Co-authored-by: Rustan Leino <leino@amazon.com>
Co-authored-by: Rustan Leino <leino@amazon.com>
Co-authored-by: Rustan Leino <leino@amazon.com>
Co-authored-by: Rustan Leino <leino@amazon.com>
RustanLeino
RustanLeino previously approved these changes Feb 9, 2023
@davidcok davidcok merged commit f224f9a into dafny-lang:master Feb 10, 2023
@davidcok davidcok deleted the cok-misc-docs-4 branch February 10, 2023 19:16
davidcok added a commit that referenced this pull request Mar 9, 2023
Fixes #3398
Follows on #3456
<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>

---------

Co-authored-by: davidcok <davidcok@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants