Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4287 gutter highlight before project pr #4308

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

MikaelMayer
Copy link
Member

Fixes #4287

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@MikaelMayer MikaelMayer force-pushed the fix-4287-gutter-highlight-before-project-pr branch from cb2c7e9 to 3bbabae Compare July 19, 2023 21:11
@MikaelMayer MikaelMayer changed the base branch from master to main-4.2 July 19, 2023 21:22
@robin-aws robin-aws enabled auto-merge (squash) July 19, 2023 23:44
docs/dev/news/4287.fix Outdated Show resolved Hide resolved
@@ -97,6 +97,10 @@ public class ClientBasedLanguageServerTest : DafnyLanguageServerTestBase, IAsync
NotificationHandler.For<FileVerificationStatus>(verificationStatusReceiver.NotificationReceived));
}

public record Change(Range range, String inserted);

public record Changes(List<Change> changes);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one actually being used?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not according to Rider's Find Usages for me - removed and will let CI call us a liar. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I declared it but ended up not using it, good finding!

@robin-aws robin-aws merged commit d4ba007 into main-4.2 Jul 20, 2023
18 checks passed
@robin-aws robin-aws deleted the fix-4287-gutter-highlight-before-project-pr branch July 20, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gutter highlighting broken
3 participants