Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove polyfill.io in the toc page #5141

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Mar 2, 2024

Description

Dafny documentation site page https://dafny.org/latest/toc includes a polyfill from polyfill.io for MathJax. The PR replaces polyfill.io with cdnjs.cloudflare.com/polyfill.


polyfill.io was acquired by a China-based CDN company "Funnull", see the announcement from the polyfill.io domain owner's Twitter and https://github.com/polyfillpolyfill/polyfill-service/issues/2834. Despite Funnull's claims of operating in the United States, the predominance of Simplified Chinese on its website suggests otherwise, and it turns out that "Funnull" is notorious for providing service for the betting and pornography industries.

The original creator of the polyfill.io has voiced his concern on Twitter. And since the acquisition, numerous issues have emerged (polyfillpolyfill/polyfill-service#2835, polyfillpolyfill/polyfill-service#2838, alist-org/alist#6100), rendering the polyfill.io service extremely unstable. Since then, Fastly (Announcement) and Cloudflare (Announcement) has hosted their own instances of polyfill.io service.

How has this been tested?

No actual code changes.


By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@fabiomadge fabiomadge changed the title docs: replace polyfill.io in the toc page docs: remove polyfill.io in the toc page Mar 4, 2024
@fabiomadge
Copy link
Collaborator

Thanks! This appears unused to me anyway, so I removed it. Does that sound reasonable to you?

@SukkaW
Copy link
Contributor Author

SukkaW commented Mar 4, 2024

Thanks! This appears unused to me anyway, so I removed it. Does that sound reasonable to you?

@fabiomadge

As long as the page doesn't require MathJax, it is OK to remove both of them!

@fabiomadge fabiomadge merged commit 54d349a into dafny-lang:master Mar 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants