Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds analog heat +fx. #50

Merged
merged 1 commit into from Aug 4, 2023
Merged

feat: adds analog heat +fx. #50

merged 1 commit into from Aug 4, 2023

Conversation

ianhundere
Copy link
Contributor

adds a new device, analog heat +fx. i haven't tested yet, but lemme know if it looks good and i'll then compile/test.

@ianhundere ianhundere mentioned this pull request Aug 4, 2023
@ianhundere
Copy link
Contributor Author

ianhundere commented Aug 4, 2023

i think it works?

❯ overwitch-cli -l
0: Analog Heat +FX (ID 1935:0020) at bus 003, address 037

edit: i tried playing files and got the following with my current commit

❯ overwitch-cli -l
0: Analog Heat +FX (ID 1935:0020) at bus 003, address 039
❯ overwitch-play -n 0  ~/Desktop/snds/harmonic/0005\ 12-Audio-1.Converted.wav
ERROR:main-play.c:164:(run_play): Number of channels do not match inputs
ERROR:main-play.c:196:(run_play): generic error

so i tried bumping the number of inputs/outputs down to 2 with the following results:

❯ overwitch-cli -l
0: Analog Heat +FX (ID 1935:0020) at bus 003, address 039
❯ overwitch-play -n 0  ~/Desktop/snds/harmonic/0005\ 12-Audio-1.Converted.wav
ERROR:engine.c:328:(cb_xfr_audio_in): o2p: Error on USB audio transfer: LIBUSB_TRANSFER_OVERFLOW
ERROR:engine.c:328:(cb_xfr_audio_in): o2p: Error on USB audio transfer: LIBUSB_TRANSFER_OVERFLOW

@dagargo
Copy link
Owner

dagargo commented Aug 4, 2023

Everything looks right to me.

In the first error, I guess you're trying to play a 2 audio channels file thru a 4 audio channels device.
Can you check this?

$ sox --i ~/Desktop/snds/harmonic/0005\ 12-Audio-1.Converted.wav

You can use overwitch-record to record a 4 channels audio sample that you can later play with overwitch-play. Is this working for you?

The second error is due to bumping the tracks amount as the tracks must match the ones in the USB packets.

Have you tried just running overwitch? It's the GUI and should just work in a JACK environment.

@dagargo dagargo self-assigned this Aug 4, 2023
@ianhundere
Copy link
Contributor Author

ianhundere commented Aug 4, 2023

Can you check this?

❯ sox --i ~/Desktop/snds/harmonic/0005\ 12-Audio-1.Converted.wav

Input File     : '/home/ianfundere/Desktop/snds/harmonic/0005 12-Audio-1.Converted.wav'
Channels       : 2
Sample Rate    : 44100
Precision      : 8-bit
Duration       : 00:00:05.39 = 237637 samples = 404.145 CDDA sectors
File Size      : 479k
Bit Rate       : 712k
Sample Encoding: 8-bit Unsigned Integer PCM

You can use overwitch-record to record a 4 channels audio sample that you can later play with overwitch-play. Is this working for you?

yup, this worked. 🎉

Have you tried just running overwitch? It's the GUI and should just work in a JACK environment.

Screenshot from 2023-08-04 13-24-13

looks good, i'll continue testing and report back.

@ianhundere
Copy link
Contributor Author

ianhundere commented Aug 4, 2023

okay, more testing...after running overwitch and then going to my daw, bitwig, i was able to assign the respective inputs/outputs and i confirmed input coming from the AH into the daw...so, i think it all works?

this did happen at one point as i was choosing AH inputs in the daw:

❯ overwitch
zsh: segmentation fault (core dumped)  overwitch

edit: happened a couple more times, and i think, each time it was when i was configuring channels in the daw:

❯ overwitch
zsh: segmentation fault (core dumped)  overwitch
❯ overwitch
zsh: segmentation fault (core dumped)  overwitch

@ianhundere
Copy link
Contributor Author

@dagargo so i think this is ready to merge? 🤔

@dagargo dagargo merged commit 3ea11c3 into dagargo:master Aug 4, 2023
@ianhundere ianhundere deleted the adds_ah+fx branch August 4, 2023 17:46
@dagargo
Copy link
Owner

dagargo commented Aug 4, 2023

Looks like it's working well so... Merged.

Regarding the segmentation fault, could you try to replicate the issue while running gdb or open the core file in gdb to get more information or the backtrace? Could you open an issue to report your findings?

each time it was when i was configuring channels in the daw:

I don't think this has happened to me but I'll try to replicate it.

@ianhundere
Copy link
Contributor Author

Regarding the segmentation fault, could you try to replicate the issue while running gdb or open the core file in gdb to get more information or the backtrace? Could you open an issue to report your findings?

done and done:
#51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants