Skip to content

Commit

Permalink
disable docker socket support until we have security in place
Browse files Browse the repository at this point in the history
Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
  • Loading branch information
aluzzardi committed Jun 7, 2021
1 parent ac34df3 commit 2671e5f
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
5 changes: 0 additions & 5 deletions environment/pipeline.go
Original file line number Diff line number Diff line change
Expand Up @@ -468,11 +468,6 @@ func (p *Pipeline) mount(ctx context.Context, dest string, mnt *compiler.Value)
llb.Scratch(),
llb.Tmpfs(),
), nil
case "docker.sock":
return llb.AddSSHSocket(
llb.SSHID(solver.DockerSocketID),
llb.SSHSocketTarget(dest),
), nil
default:
return nil, fmt.Errorf("invalid mount source: %q", s)
}
Expand Down
2 changes: 1 addition & 1 deletion stdlib/dagger/op/op.cue
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ package op
// `true` means also ignoring the mount cache volumes
always?: true | *false
dir: string | *"/"
mount: [string]: "tmpfs" | "cache" | "docker.sock" | {from: _, path: string | *"/"} | {secret: _}
mount: [string]: "tmpfs" | "cache" | {from: _, path: string | *"/"} | {secret: _}
// Map of hostnames to ip
hosts?: [string]: string
// User to exec with (if left empty, will default to the set user in the image)
Expand Down
1 change: 1 addition & 0 deletions tests/compute.bats
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ setup() {
}

@test "compute: docker socket" {
skip "docker socket support disabled"
run "$DAGGER" compute "$TESTDIR"/compute/dockersocket
}

Expand Down

0 comments on commit 2671e5f

Please sign in to comment.