Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port CUE SDK to Dagger Engine 0.3 #3565

Closed
wants to merge 21 commits into from
Closed

Conversation

jlongtine
Copy link
Contributor

@jlongtine jlongtine commented Oct 26, 2022

CUE SDK port

Starts the implementation of #3121

Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
@jlongtine jlongtine marked this pull request as ready for review November 16, 2022 21:50
@shykes
Copy link
Contributor

shykes commented Nov 16, 2022

Awesome! Is this something we should plan to release, or the first in a series of PRs to get us to a releaseable state?

@jlongtine
Copy link
Contributor Author

jlongtine commented Nov 16, 2022

Awesome! Is this something we should plan to release, or the first in a series of PRs to get us to a releaseable state?

That's an open question for me, as well, @shykes. I think that depends on a few factors.

Some context may be helpful?

This PR gets us to ~85%-90% coverage of the core Europa APIs. You can get more specifics on what is working/missing in #3121.

TLDR, though, is:

  • Secrets support is not good (currently saving new Secrets as files... which has the plaintext in the ID + saves them in the buildkit cache -- I personally would not release until we get this sorted)
  • core.#Push, core.#Pull, and core.GitPull all are missing auth, which makes it rather difficult to use with private registries. We've seen users hitting this in the Go SDK, as well.
  • Sockets are unsupported
  • Cache declarations that used to work won't for now

All in all, it's basically as implemented as it can be, given the current state of the v0.3 engine. But, I'm confident there are a bunch of plans that will break if we release as is.

My recommendation would be the latter.

I don't think we can consider this a replacement for Europa until things like core.#Exec & {always: true} work.

That said, I don't know when the things I'll need to get to a higher coverage or greater security will be available or prioritized. And, as such, it may take a while for a fuller compatibility build to be available.

Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
solver/solver.go Outdated Show resolved Hide resolved
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
@dolanor
Copy link
Contributor

dolanor commented Dec 1, 2022

So it seems this PR is depending on some other work?
Is it possible to make it explicit in the OP? And maybe let it as a WIP until everything is available and implemented? Or use some label to document that? (so we can filter on the top level item that need to be merged first?)

@github-actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants