Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminology change #368

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Terminology change #368

merged 3 commits into from
Apr 27, 2021

Conversation

shykes
Copy link
Contributor

@shykes shykes commented Apr 24, 2021 •
edited
Loading

  • Rename “deployment” to “environment”
  • Rename “deployment plan” to just “plan”
  • Light documentation upgrades along the way

@shykes
Rename "deployment" to "environment": docs.
6a3501f 
Signed-off-by: Solomon Hykes <sh.github.6811@hykes.org>
@shykes
Rename "deployment" to "environment": code
5d3dfb3 
Signed-off-by: Solomon Hykes <sh.github.6811@hykes.org>
@shykes shykes changed the title Work in progress: terminology change Terminology change Apr 27, 2021
@shykes
Rename "deployment" to "environment": tests
0e00875 
Signed-off-by: Solomon Hykes <sh.github.6811@hykes.org>
@shykes shykes requested a review from samalba April 27, 2021 20:52
@shykes
Copy link
Contributor Author

shykes commented Apr 27, 2021

@samalba @aluzzardi ok to merge? As usual we can always change it again (until launch at least :)

@samalba
Copy link
Contributor

samalba commented Apr 27, 2021

Few minor comments:

  • I would remove the file cmd/spec.cue
  • The file examples/README.md is out of date, we should update in a follow-up PR

@shykes shykes merged commit d7391fe into dagger:main Apr 27, 2021
@shykes
Copy link
Contributor Author

shykes commented Apr 27, 2021

I need the spec file to iterate on future CLI changes. It’s a useful middle ground between a written proposal, and a full implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samalba samalba samalba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shykes @samalba