Directory+File: add withTimestamps
for normalizing file/dir timestamps
#4106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4104
Adds the following API:
Bikeshedding opportunities:
withTimestamps
nametimestamp
param nametimestamp
param type (should we have aUnixSeconds
scalar? or just rename the param tounixSeconds
?)In hindsight there might be a less confusing name - we've got a plural
withTimestamps
yet a singulartimestamp
param. The name is plural because it modifies the contents recursively to a single timestamp.One caveat: when mounting the
Directory
into a container the mountpoint itself won't have the desired timestamp. So if you dotar -cf - -C /dir .
you'll still end up with an unstabletar
archive because of the timestamp on/dir
. I tried a few tricks with LLB but none of them worked. The workaround in this case is to just target the contents instead (*
instead of.
).