New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build args to Dockerfile build #4207
Conversation
2cc2695
to
2d75dd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the already discussed need for nodejs support for input types, shipit once that test case is passing :-)
The engine tests were failing due to this (private discussion). We addressed the root cause and re-ran the failing tests. When the Node.js tests are passing, this is good to merge @jlongtine. cc @dolanor @slumbering |
#4247 has been merged (thanks @TomChv ) |
Signed-off-by: Joel Longtine <joel@longtine.io>
2d75dd0
to
9439a52
Compare
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
b8158c6
to
77e16f3
Compare
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
77e16f3
to
5dff48e
Compare
Resolves #3574
Signed-off-by: Joel Longtine joel@longtine.io