Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build args to Dockerfile build #4207

Merged
merged 4 commits into from Dec 22, 2022
Merged

Conversation

jlongtine
Copy link
Contributor

Resolves #3574

Signed-off-by: Joel Longtine joel@longtine.io

Copy link
Contributor

@sipsma sipsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the already discussed need for nodejs support for input types, shipit once that test case is passing :-)

@jlongtine
Copy link
Contributor Author

LGTM other than the already discussed need for nodejs support for input types, shipit once that test case is passing :-)

Thanks @sipsma! 🙏🏻

Gonna work with @dolanor on that!

@gerhard
Copy link
Member

gerhard commented Dec 19, 2022

The engine tests were failing due to this (private discussion). We addressed the root cause and re-ran the failing tests.

When the Node.js tests are passing, this is good to merge @jlongtine. cc @dolanor @slumbering

image

@dolanor
Copy link
Contributor

dolanor commented Dec 22, 2022

#4247 has been merged (thanks @TomChv )
I tried locally by rebasing this one on top of the #4247, and it worked.
So you can just rebase and merge when you want @jlongtine

Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
@jlongtine jlongtine merged commit b21f406 into dagger:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Build Args for Dockerfiles
5 participants