Refactor NodeJS codegen #4360
Merged
Refactor NodeJS codegen #4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomChv
force-pushed
the
nodejs-refacto-codegen
branch
from
1e3c857
to
7f9f4a0
Compare
TomChv
force-pushed
the
nodejs-refacto-codegen
branch
2 times, most recently
from
b31e278
to
d7cd479
Compare
TomChv
force-pushed
the
nodejs-refacto-codegen
branch
from
d7cd479
to
80c02da
Compare
Not at all :D |
TomChv
force-pushed
the
nodejs-refacto-codegen
branch
from
80c02da
to
b9c258a
Compare
TomChv
force-pushed
the
nodejs-refacto-codegen
branch
from
b9c258a
to
efeaa32
Compare
|
I'll check this one tomorrow! |
TomChv
force-pushed
the
nodejs-refacto-codegen
branch
from
efeaa32
to
a00d965
Compare
|
cc @dolanor ☝️ |
dolanor
commented
Feb 9, 2023
There was a problem hiding this comment.
Excellent work, I think you really streamlined it better.
There are a few -}} that can be avoided I think.
I would need a new version of the client generated code part of the PR to make sure that we don't have regression now that we removed most of codegen unit test.
Can you run a go run ./cmd/client-gen/ --lang nodejs -o ./sdk/nodejs/api/client.gen.ts and commit it with this PR so we see if we didn't break anything during the refactor?
|
@dolanor as you're the author of this PR, do you think it could be possible for you to make those changes above in order to ship this PR ? |
TomChv
force-pushed
the
nodejs-refacto-codegen
branch
from
431c71a
to
c8f8260
Compare
|
I'm gonna rebase this and fix conflicts. |
Signed-off-by: Tanguy ⧓ Herrmann <tanguy@dagger.io>
VSCode has an extension for Go template but it only parses files with *.go.tpml or *.gtpl extension. To enable this capabilities, we rename *.ts.tpml to *.ts.gtpl. Simplify types.ts.tpml by merging external template in it. This removes type, type_field_comment and object_comment template. Add comments on some template files. Signed-off-by: Tom Chauveau <tom.chauveau@epitech.eu>
Merge returns template into files. Add comments. Make templates more readable. Signed-off-by: Tom Chauveau <tom.chauveau@epitech.eu>
Signed-off-by: Tom Chauveau <tom.chauveau@epitech.eu>
Signed-off-by: Tom Chauveau <tom.chauveau@epitech.eu>
Signed-off-by: Tanguy ⧓ Herrmann <tanguy@dagger.io>
dolanor
force-pushed
the
nodejs-refacto-codegen
branch
2 times, most recently
from
0021f39
to
56a8c9f
Compare
- (only use it on template comments {{- /* xxx */ -}} or if not possible
to use a `{{- "" }}` on the next line.
- make templates directive indented by `\t`. Only use ` ` for actual TS
code indentation
Signed-off-by: Tanguy ⧓ Herrmann <tanguy@dagger.io>
dolanor
force-pushed
the
nodejs-refacto-codegen
branch
from
56a8c9f
to
819df4a
Compare
|
Ok, good to review/merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
}}instead of-}}as we already have{{-in general)