Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Raise warnings on deprecated API methods #5209

Merged
merged 1 commit into from May 26, 2023

Conversation

helderco
Copy link
Contributor

This is Python's implementation of #4855

Example output:

❯ python examples/client-simple/say.py "hi"
/Users/helder/Projects/dagger/sdk/python/examples/client-simple/say.py:15: DeprecationWarning: Method "exec" is deprecated. Replaced by "with_exec".
  .exec(["pip", "install", "cowsay"])
  __
| hi |
  ==
  \
   \
     ^__^
     (oo)\_______
     (__)\       )\/\
         ||----w |
         ||     ||

Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
@helderco helderco force-pushed the sdk/python/deprecation-warnings branch from ee9a364 to e57ab52 Compare May 26, 2023 15:17
Copy link
Member

@grouville grouville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice add-on 👌

@helderco helderco merged commit 632af1c into dagger:main May 26, 2023
18 checks passed
@helderco helderco deleted the sdk/python/deprecation-warnings branch May 26, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants