Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Directory.sync #5414

Merged

Conversation

helderco
Copy link
Contributor

@helderco helderco commented Jul 6, 2023

Part of #5065

@helderco helderco requested a review from vito July 6, 2023 13:17
@helderco helderco changed the title Add Directory.sync Add Directory.sync Jul 6, 2023
Copy link
Member

@TomChv TomChv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
@helderco helderco force-pushed the helder/dev-1564-add-support-in-directory branch from 19d1b8b to af2fba0 Compare July 7, 2023 16:23
Copy link
Contributor

@vito vito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@helderco helderco merged commit b6d92dc into dagger:main Jul 7, 2023
21 checks passed
@helderco helderco deleted the helder/dev-1564-add-support-in-directory branch July 7, 2023 22:25
nabsul pushed a commit to nabsul/dagger that referenced this pull request Jul 9, 2023
* Add Directory.sync

Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>

* Fix services

Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>

* Improve scratch handling

Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>

---------

Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants