Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v0.6.4 release #5486

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Prepare v0.6.4 release #5486

merged 6 commits into from
Jul 19, 2023

Conversation

gerhard
Copy link
Member

@gerhard gerhard commented Jul 19, 2023

The primary difference as of this release is that we generate release notes with changie before releasing, and we use this file in GoReleaser. For now this is manual, but it will be automated as soon as we are confident that this is the right approach.

Opening as a draft PR, want to double-check in my fork that releasing works as expected (wouldn't want to have to fix issues half-way through releasing).

These happen on every merge commit, they are not nightlies (even though
GoReleaser calls them that).

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
.goreleaser.yml Outdated Show resolved Hide resolved
@gerhard gerhard force-pushed the prepare-0.6.4-release branch 3 times, most recently from ba802f0 to 746e151 Compare July 19, 2023 15:55
@helderco
Copy link
Contributor

Do you need to run changie merge in all four directories?

    changie batch patch

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
Replace anything that GoReleaser generates with our changie generated
release notes.

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
This will be automated, the first step is to document.

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
@gerhard
Copy link
Member Author

gerhard commented Jul 19, 2023

@helderco: Do you need to run changie merge in all four directories?

No, the SDK release notes are created after the Engine & CLI get bumped. So after the Engine & CLI are released, the release notes for the SDKs start.

@gerhard
Copy link
Member Author

gerhard commented Jul 19, 2023

I just checked on my fork that this works as expected: https://github.com/gerhard/dagger/releases/tag/v0.6.4

image

Converting this PR to ready for review so that we can finally merge & produce the Engine & CLI releases.

@gerhard gerhard marked this pull request as ready for review July 19, 2023 16:22
@gerhard gerhard requested a review from helderco July 19, 2023 16:22
@gerhard gerhard merged commit 0889c09 into dagger:main Jul 19, 2023
36 checks passed
@gerhard gerhard deleted the prepare-0.6.4-release branch July 19, 2023 16:28
sipsma pushed a commit to sipsma/dagger that referenced this pull request Jul 29, 2023
* Clarify that nightly release is actually dev release

These happen on every merge commit, they are not nightlies (even though
GoReleaser calls them that).

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>

* Generate Engine & CLI release notes for the upcoming version

    changie batch patch

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>

* Use changie generated changelog for the release notes

Replace anything that GoReleaser generates with our changie generated
release notes.

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>

* Bump GoReleaser to latest stable

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>

* Replace deprecated --rm-dist in GoRelease with --clean

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>

* Add release notes PR to RELEASING

This will be automated, the first step is to document.

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>

---------

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants