Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry: fix labels not being included #5602

Merged
merged 2 commits into from
Aug 9, 2023
Merged

telemetry: fix labels not being included #5602

merged 2 commits into from
Aug 9, 2023

Conversation

vito
Copy link
Contributor

@vito vito commented Aug 9, 2023

  1. Backfill integration test for labels being sent to Cloud
  2. Store collected labels on Client and include them in every ClientMetadata

@vito vito requested review from marcosnils and sipsma August 9, 2023 16:07
@marcosnils
Copy link
Contributor

LGTM! left a small nit comment.

gerhard
gerhard approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@gerhard gerhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚀

@vito
telemetry: fix labels not being included
7bbb557 
Signed-off-by: Alex Suraci <alex@dagger.io>
@vito
labels: durable to not having an origin
af113df 
Signed-off-by: Alex Suraci <alex@dagger.io>
@vito vito merged commit 06128c2 into dagger:main Aug 9, 2023
20 checks passed
@vito vito deleted the fix-label-telemetry branch August 9, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerhard gerhard gerhard approved these changes

@sipsma sipsma sipsma approved these changes

@marcosnils marcosnils Awaiting requested review from marcosnils

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vito @marcosnils @gerhard @sipsma