chore: add engine logs for failed queries #5827
Conversation
This can be massively helpful for debugging - especially when debugging weird failures. The errors are only added as debug level, since these errors generally aren't actually critical to the server. Signed-off-by: Justin Chadwell <justin@dagger.io>
There was a problem hiding this comment.
Not blocking, but curious what type of error this helped with. Maybe we've troubleshooting things in different ways. I guess I always see the error bubble up to the client, and don't spend a lot of time looking at engine logs. (OK I do, but always grepped for !!! which I sprinkle in one-off logs while troubleshooting.)
|
I think I was seeing weird differences in error messages between At some point, I think we can also recover the stack traces in the dagger engine, which we can't do in the client (I think, since the error is already formatted at that point), though I got a little stuck with doing that - so this was a fine stopgap till then. |
This can be massively helpful for debugging - especially when debugging weird failures.
The errors are only added as debug level, since these errors generally aren't actually critical to the server.