fix: Clear defaultArgs on withEntrypoint by default

[helderco]

Fixes #6044

What?

When Container.withEntrypoint is set, it will clear Container.defaultArgs, unless withEntrypoint(args: [...], keepDefaultArgs: true) is set.

Breaking change

May have low impact since in most cases users are probably erasing defaultArgs manually. Only breaks for users that change the entrypoint but depend on the default args remaining the same.

[helderco]

Reframing as a fix, since I agree with @jedevc:

I think I read it more of a "fix", which brings the behaviour of dagger's entrypoint+args inline with how users expect it to work with docker/other runtimes.

- Originally posted in Discord

\cc @gerhard

[jedevc]

LGTM! Not a blocker: but should this behavior also apply to withoutEntrypoint from #6278? Since the entrypoint is changing, the args wouldn't necessarily apply. I'd argue we should also have the same behavior there for consistency.

[helderco]

[...] should this behavior also apply to withoutEntrypoint from #6278? Since the entrypoint is changing, the args wouldn't necessarily apply. I'd argue we should also have the same behavior there for consistency.

Yeah, that's a good point!