feat: add git ref graphql field #6376
Conversation
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
It's unfortunate that this has been sitting open for as long as it did, and now there are a bunch of conflicts to deal with. How do you want to proceed @jedevc? |
|
Rebased, and also pulled in my fix from buildkit for moby/buildkit@6a8d2ca (since we have a copy-paste job, I'd forgotten about that). As a follow-up, I'll work on removing our custom git source if I can. |
Signed-off-by: Justin Chadwell <me@jedevc.com>
This is a cherry-pick of moby/buildkit@6a8d2ca Signed-off-by: Justin Chadwell <me@jedevc.com>
| var ( | ||
| partialRef = "refs/" + strings.TrimPrefix(ref, "refs/") | ||
| headRef = "refs/heads/" + strings.TrimPrefix(ref, "refs/heads/") | ||
| tagRef = "refs/tags/" + strings.TrimPrefix(ref, "refs/tags/") | ||
| annotatedTagRef = tagRef + "^{}" | ||
| ) | ||
| var sha, headSha, tagSha string | ||
| for _, line := range lines { | ||
| lineSha, lineRef, _ := strings.Cut(line, "\t") | ||
| switch lineRef { | ||
| case headRef: | ||
| headSha = lineSha | ||
| case tagRef, annotatedTagRef: | ||
| tagSha = lineSha | ||
| case partialRef: | ||
| sha = lineSha | ||
| } |
There was a problem hiding this comment.
Could use a quick comment explaining what this does
Looks like it's looking for matches by checking for potential expanded paths for the given ref in the output?
There was a problem hiding this comment.
Ah this is pulled directly from moby/buildkit@6a8d2ca, and was part of my logic for starting on #6560.
Ideally I'd like to just not need to duplicate any of this code from buildkit, but sadly I think this is still required until I can submit some upstream changes.
Also added a comment for this though.
Signed-off-by: Justin Chadwell <me@jedevc.com>
|
@jedevc Sorry for not getting back to you, my github notifications are still messed up. The |
Fix #6375.
As suggested by @sagikazarmark, it feels odd to put
refs/pull/5/mergeand similar into acommit/branch/tagselection - it's a ref, so we should have a genericrefselection.To handle the rust codegen case, we need to do some magic since
refis a strict keyword. We can resolve this using a raw identifier. @dagger/sdk-rust I've hacked something in to get the codegen to work, but let me know if you want to take a different approach.In general, it's a little bit strange that we have so many functions that all have exactly the same underlying implementation - e.g. you can put a commit ID in a
branchand it works fine. Maybe we should consider prefixing it withrefs/headstobranch, and prefixing withrefs/tagstotag- we could then require that the args to commit be a SHA ID.Then
refwould be the only "generic" field that passes directly to buildkit.