fix: remove global Client property on generated structs #6716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in discord: https://discord.com/channels/707636530424053791/1120503349599543376/1209815200023191662
#6680 made
Client
andQuery
reserved fields on all objects - but it's quite common to defineClient
on objects.This patch is a little bit of a refactoring I've wanted to do for a while - it essentially allows binding clients to
querybuilder.Selection
s, which means we can pretty much do away withClient
+Query
combinations, now we only need to trackQuery
(and the client gets automagically inherited).We still have this issue for
Query
. Gonna keep thinking about this one.