New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Finish isolating sessions to each client #6916
Conversation
Signed-off-by: Erik Sipsma <erik@dagger.io>
Signed-off-by: Erik Sipsma <erik@dagger.io>
@@ -28,11 +28,12 @@ const ( | |||
) | |||
|
|||
type ClientMetadata struct { | |||
// ClientID is unique to every session created by every client | |||
// ClientID is unique to each client. The main client's ID is the empty string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: fix this doc string; the client ID is now what used to be ModuleCallerDigest, so it's actually a non-unique content hash for all clients other than "main callers" from the host.
Signed-off-by: Erik Sipsma <erik@dagger.io>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Just to update, I extracted a bit of this out to #7213 in order to get bug fixes in faster. Also been chipping away locally at a re-work of this PR locally as I got thing like 95% working but then hit a corner case that called for a different approach. I'm trying to do it in such a way that it cleans up as many related things as possible since we accumulated quite a bit of cruft over the last 6ish months adding module support. The biggest things that I may end up incorporating here are:
Obviously don't want the scope of this to grow out of control either, so seeing what makes sense to do here still and what can be follow ups. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. |
This is the last part of the saga around #6747 that fully isolates sessions to each client and thus enables support for passing host unix sockets to modules, plugging some existing holes in our secret isolation, etc.
This PR doesn't have all that yet, been in the process of rebuilding it cleanly after an initial messy prototype. Sending it out anyways because what I have here seems to fix the problem in #6914, so may want to merge a minimum safe changeset here early.
@vito unfortunately these are the changes I was referring to that may cause rebase headaches with your OTEL PR (and there's more coming on top of the commits already here), so we'll have to sort that out if we merge this soon.