fix: avoid internal error for unicode path elements #6925
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue (found at kubecon 🎉):
A similar issue was resolved in buildkit a while back: moby/buildkit#3946
However, because we have our own filesync implementation, we need our own fix. To do this, I've just imported the helpers from upstream, in a copy-paste job (since they're not exported, and they probably shouldn't be, it's not an external implementation detail) - this impl is tested pretty thoroughly upstream and in the last buildkit release.