Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid internal error for unicode path elements #6925

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

jedevc
Copy link
Member

@jedevc jedevc commented Mar 25, 2024

The issue (found at kubecon 🎉):

$ pwd
/tmp/work/fooé/test
$ dagger init --sdk=go --source=.
✘ ModuleSource.resolveContextPathFromCaller: String! 0.0s

Error: failed to get configured module: failed to get local root path: input: moduleSource.resolveContextPathFromCaller resolve: failed to find up root: failed to lstat .git: failed to create diff copy client: rpc error: code = Internal desc = rpc error: code = Internal desc = header key "dir-name" contains value with non-printable ASCII characters

A similar issue was resolved in buildkit a while back: moby/buildkit#3946

However, because we have our own filesync implementation, we need our own fix. To do this, I've just imported the helpers from upstream, in a copy-paste job (since they're not exported, and they probably shouldn't be, it's not an external implementation detail) - this impl is tested pretty thoroughly upstream and in the last buildkit release.

@jedevc jedevc requested a review from sipsma March 25, 2024 14:51
@jedevc jedevc added this to the v0.10.3 milestone Mar 25, 2024
@jedevc
Copy link
Member Author

jedevc commented Mar 25, 2024

Chucking this into the milestone, since it's a reasonably trivial fix.

Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Copy link
Member

@gerhard gerhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 🚀

@jedevc jedevc merged commit 3e79966 into dagger:main Mar 26, 2024
43 checks passed
@jedevc jedevc deleted the fix-unicode-paths branch March 26, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants