Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Remove deprecated schema fields #6934

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jedevc
Copy link
Member

@jedevc jedevc commented Mar 26, 2024

Removes previously deprecated fields - we've had these fields deprecated for several months at this point, so hopefully this should cause minimal impact.

@jedevc jedevc added this to the v0.11.0 milestone Mar 26, 2024
@jedevc jedevc requested review from vito, helderco and sipsma March 26, 2024 12:18
@jedevc jedevc requested review from a team as code owners March 26, 2024 12:18
@jedevc jedevc marked this pull request as draft March 26, 2024 12:22
@jedevc jedevc force-pushed the remove-deprecated-schemas branch 3 times, most recently from 5b97378 to a28466e Compare March 26, 2024 13:35
@jedevc jedevc modified the milestones: v0.11.0, v0.10.x Apr 2, 2024
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

github-actions bot commented May 2, 2024

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@jedevc jedevc removed the kind/stale label Jun 24, 2024
@jedevc jedevc force-pushed the remove-deprecated-schemas branch 2 times, most recently from b1a2a2f to 306331e Compare June 24, 2024 14:28
@jedevc jedevc marked this pull request as ready for review June 24, 2024 15:43
@jedevc jedevc requested a review from a team as a code owner June 24, 2024 15:43
@jedevc jedevc force-pushed the remove-deprecated-schemas branch from 306331e to 768c441 Compare June 24, 2024 15:45
This fields have been deprecated for several months at this point - so
we should finally remove them (in v0.11.0, which is a minor release).
Use of these functions outside of SDK internals was low anyways, so we
should see minimal breakages even if users were using these.

Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc jedevc changed the title Remove deprecated schema fields 💥 Remove deprecated schema fields Jun 24, 2024
@jedevc jedevc added the kind/breaking Breaking Change label Jun 24, 2024
Copy link
Contributor

@helderco helderco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preemptively approving as it lgtm.

Copy link
Contributor

github-actions bot commented Jul 9, 2024

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants