refactor(sdk/rust): Into -> From #6959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjuulh
force-pushed
the
refactor/rust-sdk/into-to-from
branch
3 times, most recently
from
4bfa958
to
275d689
Compare
kjuulh
force-pushed
the
refactor/rust-sdk/into-to-from
branch
2 times, most recently
from
305088b
to
0c9dc17
Compare
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
jedevc
reviewed
Apr 25, 2024
Signed-off-by: kjuulh <contact@kjuulh.io> refactor(sdk/rust): Into -> From Signed-off-by: kjuulh <contact@kjuulh.io>
Signed-off-by: kjuulh <contact@kjuulh.io>
Signed-off-by: kjuulh <contact@kjuulh.io>
kjuulh
force-pushed
the
refactor/rust-sdk/into-to-from
branch
from
9dd30f6
to
f6a6840
Compare
Signed-off-by: kjuulh <contact@kjuulh.io>
jedevc
approved these changes
May 1, 2024
|
@jedevc I can't really tell with the dagger cli errors happening. I am getting a 404 against dagger.cloud. I am guessing that it is probably fine to merge? |
|
Yeah, this is looking good, sorry @kjuulh - we're having a lot of flakiness which we're working on resolving asap 🎉 |
kpenfound
pushed a commit
to kpenfound/dagger
that referenced
this pull request
May 2, 2024
* refactor(sdk/rust): Into -> From Signed-off-by: kjuulh <contact@kjuulh.io> refactor(sdk/rust): Into -> From Signed-off-by: kjuulh <contact@kjuulh.io> * chore: remove extra clone Signed-off-by: kjuulh <contact@kjuulh.io> * chore: fix spacing Signed-off-by: kjuulh <contact@kjuulh.io> * chore: revert allow warnigns Signed-off-by: kjuulh <contact@kjuulh.io> --------- Signed-off-by: kjuulh <contact@kjuulh.io> Signed-off-by: kpenfound <kyle@dagger.io>
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
* refactor(sdk/rust): Into -> From Signed-off-by: kjuulh <contact@kjuulh.io> refactor(sdk/rust): Into -> From Signed-off-by: kjuulh <contact@kjuulh.io> * chore: remove extra clone Signed-off-by: kjuulh <contact@kjuulh.io> * chore: fix spacing Signed-off-by: kjuulh <contact@kjuulh.io> * chore: revert allow warnigns Signed-off-by: kjuulh <contact@kjuulh.io> --------- Signed-off-by: kjuulh <contact@kjuulh.io>
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
* refactor(sdk/rust): Into -> From Signed-off-by: kjuulh <contact@kjuulh.io> refactor(sdk/rust): Into -> From Signed-off-by: kjuulh <contact@kjuulh.io> * chore: remove extra clone Signed-off-by: kjuulh <contact@kjuulh.io> * chore: fix spacing Signed-off-by: kjuulh <contact@kjuulh.io> * chore: revert allow warnigns Signed-off-by: kjuulh <contact@kjuulh.io> --------- Signed-off-by: kjuulh <contact@kjuulh.io>
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
* refactor(sdk/rust): Into -> From Signed-off-by: kjuulh <contact@kjuulh.io> refactor(sdk/rust): Into -> From Signed-off-by: kjuulh <contact@kjuulh.io> * chore: remove extra clone Signed-off-by: kjuulh <contact@kjuulh.io> * chore: fix spacing Signed-off-by: kjuulh <contact@kjuulh.io> * chore: revert allow warnigns Signed-off-by: kjuulh <contact@kjuulh.io> --------- Signed-off-by: kjuulh <contact@kjuulh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of a few cleanup prs, I am fixing some of the best practices in gen.rs so that we don't ship as many warnings