fix: windows dagger init command #7003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedevc
force-pushed
the
fix-windows-dagger-init
branch
from
7094354
to
41cee9b
Compare
jedevc
force-pushed
the
fix-windows-dagger-init
branch
2 times, most recently
from
ed45198
to
f33cbbb
Compare
jedevc
commented
Apr 9, 2024
| @@ -924,7 +924,7 @@ func (s *moduleSchema) collectCallerLocalDeps( | |||
| return nil, fmt.Errorf("error unmarshaling config at %s: %s", configPath, err) | |||
| } | |||
|
|
|||
| case strings.Contains(err.Error(), "no such file or directory"): | |||
| case strings.Contains(err.Error(), "no such file or directory") || strings.Contains(err.Error(), "not found"): | |||
There was a problem hiding this comment.
Yeah this is fun 馃槃 there's just different error message strings depending on whether the client is linux/windows.
I can't think of a neat way round this really.
jedevc
commented
Apr 9, 2024
jpadams
force-pushed
the
fix-windows-dagger-init
branch
from
a2ec42b
to
cc47b81
Compare
jedevc
force-pushed
the
fix-windows-dagger-init
branch
from
cc47b81
to
9c4167e
Compare
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Previously, license searching might escape the context - this was weird. Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
fix-windows-dagger-init
branch
from
9c4167e
to
8b60029
Compare
helderco
approved these changes
Apr 16, 2024
Signed-off-by: Justin Chadwell <me@jedevc.com>
This was referenced Apr 17, 2024
Closed
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
* fix: windows dagger init command Signed-off-by: Justin Chadwell <me@jedevc.com> * chore: simplify client file accessors Signed-off-by: Justin Chadwell <me@jedevc.com> * fix: ensure license searching doesn't go above context Previously, license searching might escape the context - this was weird. Signed-off-by: Justin Chadwell <me@jedevc.com> * chore: remove old commented out code Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Justin Chadwell <me@jedevc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6923 馃帀
Warning
Depends on tonistiigi/fsutil#196
Still needs some tidy-ups, but I managed to actually get this working on windows again!
Love filepaths. So fun.