chore: restore install.ps1 #7050
Conversation
.goreleaser.yml
Outdated
| - name: publish-install-sh | ||
| cmd: sh -c "aws s3 cp install.sh s3://{{ .Env.AWS_BUCKET }}/dagger/install.sh" |
There was a problem hiding this comment.
From what I can tell, there's currently no automation for this right now? This is what prevented install.ps1 from being updated in the docs in the first place.
If so, I think this is the right way to do it, we should have goreleaser release the install script.
There was a problem hiding this comment.
We do this manually because we need to invalidate CloudFront too. FTR:
If we want to do this properly, we should add it as a function - follow-up to:
If we want to do this quick & dirty, we need to also invalidate CloudFront. Relevant past comments:
There was a problem hiding this comment.
Sounds good! Hadn't realized that, I've updated the RELEASING guide to include info about doing this.
install.ps1
Outdated
| @" | ||
| --------------------------------------------------------------------------------- | ||
| Author: Alessandro Festa | ||
| Co Author: Brittan DeYoung | ||
| Dagger Installation Utility for Windows users | ||
| --------------------------------------------------------------------------------- | ||
| "@ |
There was a problem hiding this comment.
I'm not sure about keeping this, none of our other install scripts or tools have author names like this.
There was a problem hiding this comment.
I added a commit to convert this author block to a comment instead of it being output on every execution.
jpadams
force-pushed
the
restore-install-ps1
branch
from
67c6658
to
350d7b7
Compare
.goreleaser.yml
Outdated
| - name: publish-install-sh | ||
| cmd: sh -c "aws s3 cp install.sh s3://{{ .Env.AWS_BUCKET }}/dagger/install.sh" |
| # Author: Alessandro Festa | ||
| # Co Author: Brittan DeYoung | ||
| # Dagger Installation Utility for Windows users | ||
| # --------------------------------------------------------------------------------- |
There was a problem hiding this comment.
This script works fine for me. Now just need the dagger.exe that it downloads to give some output. That's the other PR :)
There was a problem hiding this comment.
This looks good to me. I haven't tested, but the shape is correct. FTR:
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Jeremy Adams <jeremy@dagger.io>
Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
restore-install-ps1
branch
from
d321152
to
6745fd2
Compare
|
Merging this since the script looks good - even if this ends up wrong, we can also update this on S3 async to our release process. |
* chore: restore install.ps1 Signed-off-by: Justin Chadwell <me@jedevc.com> * chore: Make author block comment instead of stdout Signed-off-by: Jeremy Adams <jeremy@dagger.io> * chore: update RELEASING to mention install scripts Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Justin Chadwell <me@jedevc.com> Signed-off-by: Jeremy Adams <jeremy@dagger.io> Co-authored-by: Jeremy Adams <jeremy@dagger.io>
Fix #6901.
This script was removed in 5a9c772, and we still have windows install instructions, so we should probably restore this!
I've also updated the script with a few additions, like making the function names map to the same as the unix script.