feat: added support for streaming stdout when --progress=plain

[morlay]

fix #7057

[morlay]

logs in real CI. (no idea about the color lost issue)

[morlay]

the span name is not always get cause otel emit the spans until span.End() called.
may consider set span name in log attrs too.

[jedevc]

I think this makes sense 🎉 I'm really not familiar with how frontend.go works though.

To me, it feels confusing that the logic for adding new views/etc is really complex - ideally, we'd have an interface that a new view would be able to implement. Then the fancy new progress view and the plain one would all just be implementations of that interface.

[jedevc]

There were still some color issues (particularly in the summary that's still printed at the end), so pushed a fix for that (the extra WithTTY calls can be removed once vito/progrock#14 is merged and updated).

[jedevc]

I'd like to do some further refactoring of this later, but for now, this fixes the issue, and it would be awesome to include this in v0.11.1, so going to approve now, and I'll happily iterate on this after the release.

[morlay]

@jedevc

it could ignore logs without spanName for now.

spanName := w.getSpanName(w.spanID)
if spanName == "" {
    return
}

[morlay]

@jedevc spanName may empty.

it could safe fixed by https://github.com/dagger/dagger/pull/7069/files#r1559461303

[jedevc]

@morlay can you share an example of where span is empty?

[morlay]

@morlay can you share an example of where span is empty?

this first 6: in that image.

It logs before trace span emitted.

[jedevc]

Right, yeah, I meant, do you have a publicly-available example I can run to get this?

I'm trying to understand why this can happen.

[morlay]

Right, yeah, I meant, do you have a publicly-available example I can run to get this?

I'm trying to understand why this can happen.

It from github actions logs of my tool.
https://github.com/octohelm/piper

It base dagger for container.
But could execute in local/remote hosts.
Like some build system or the Ansible did.

To make logs in same view, I reuse idtui when dagger v0.11.0 released.

So in local host execution, it will be fast.
Then got the issue. 😂

All tasks defined by cue lang.
https://github.com/octohelm/piper/blob/main/piper.cue

It could be run TTY=0 make build with this project

To see the issue should delete this condition
https://github.com/octohelm/piper/blob/main/internal/logger/steaming_exporter.go#L152

[morlay]

https://github.com/dagger/dagger/blob/main/dagql/idtui/types.go#L133

Btw, in my case. It will make my final report hide some spans. 😂

Could we make it configable?

[vito]

To me, it feels confusing that the logic for adding new views/etc is really complex - ideally, we'd have an interface that a new view would be able to implement. Then the fancy new progress view and the plain one would all just be implementations of that interface.

This view is fundamentally different so it makes sense to me. Normally we're rendering into a viewport and dynamically redrawing parts of the screen, TUI style. This one just needs to print output directly without any funny business and let it go into the scrollback infinitely, skipping past all those moving parts and disregarding screen size and all that.

In the end they're both implementing an interface, just perhaps a lower level one than you might have expected (OpenTelemetry span/log exporter).

[vito]

Could we make it configable?

Already is - if you pass -vvv (verbosity level 3) it'll show everything. Probably need that in our docs. :)

[morlay]

Already is - if you pass -vvv (verbosity level 3) it'll show everything. Probably need that in our docs. :)

but with it, the final reporter is too noisy. 😂
May some option could define the should show.

[vito]

This is a great start, but I noticed it seems impossible to interrupt it at the moment with Ctrl+C. But, I think that was already broken in plain mode, so approving anyway; this is still a net positive. I think we can merge this as-is and I can try to fix that + maybe do some refactoring after. Thanks a bunch!

[vito]

but with it, the final reporter is too noisy. 😂
May some option could define the should show.

I'd prefer to avoid a bunch of flags, but feel free to make it a param or var instead of a const, if you're using this code directly.