docs: initial github container registry integration guide #7088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Marsden <me@lukemarsden.net>
Signed-off-by: Luke Marsden <me@lukemarsden.net>
Signed-off-by: Luke Marsden <me@lukemarsden.net>
|
CI failure seems unrelated to this change? |
|
I've not reviewed in depth but a few questions off the top:
|
CI error is |
Co-authored-by: vikram-dagger <112123850+vikram-dagger@users.noreply.github.com> Signed-off-by: lukemarsden <me@lukemarsden.net>
|
Yeah, happy to move it into the GHA page as a sub-section if you think that's best! |
|
@lukemarsden OK to push changes directly to your PR? |
|
Sure please do!
lukemarsden.net
***@***.***
@lmarsden <https://twitter.com/lmarsden>
…On Wed, 17 Apr 2024 at 20:39, vikram-dagger ***@***.***> wrote:
@lukemarsden <https://github.com/lukemarsden> OK to push changes directly
to your PR?
—
Reply to this email directly, view it on GitHub
<#7088 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACATUVE2IAPT56QUZ4N2CDY53FVTAVCNFSM6AAAAABGEBRLNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRSGA4DENJZGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
|
Updated the module reference to point to This LGTM |
|
Ping @kpenfound for review |
vikram-dagger
approved these changes
Apr 25, 2024
vikram-dagger
added a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
* docs: initial github container registry integration guide Signed-off-by: Luke Marsden <me@lukemarsden.net> * docs: fix link to main.go Signed-off-by: Luke Marsden <me@lukemarsden.net> * docs: hopefully convince linter this isn't a real go file Signed-off-by: Luke Marsden <me@lukemarsden.net> * Update docs/current_docs/integrations/snippets/ghcr-workflow.yml Co-authored-by: vikram-dagger <112123850+vikram-dagger@users.noreply.github.com> Signed-off-by: lukemarsden <me@lukemarsden.net> * Integrates examplein to GitHub Actions integ page Signed-off-by: Vikram Vaswani <vikram@dagger.io> * rename Signed-off-by: Luke Marsden <me@lukemarsden.net> * bump tag Signed-off-by: Luke Marsden <me@lukemarsden.net> --------- Signed-off-by: Luke Marsden <me@lukemarsden.net> Signed-off-by: lukemarsden <me@lukemarsden.net> Signed-off-by: Vikram Vaswani <vikram@dagger.io> Co-authored-by: vikram-dagger <112123850+vikram-dagger@users.noreply.github.com> Co-authored-by: Vikram Vaswani <vikram@dagger.io>
vikram-dagger
added a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
* docs: initial github container registry integration guide Signed-off-by: Luke Marsden <me@lukemarsden.net> * docs: fix link to main.go Signed-off-by: Luke Marsden <me@lukemarsden.net> * docs: hopefully convince linter this isn't a real go file Signed-off-by: Luke Marsden <me@lukemarsden.net> * Update docs/current_docs/integrations/snippets/ghcr-workflow.yml Co-authored-by: vikram-dagger <112123850+vikram-dagger@users.noreply.github.com> Signed-off-by: lukemarsden <me@lukemarsden.net> * Integrates examplein to GitHub Actions integ page Signed-off-by: Vikram Vaswani <vikram@dagger.io> * rename Signed-off-by: Luke Marsden <me@lukemarsden.net> * bump tag Signed-off-by: Luke Marsden <me@lukemarsden.net> --------- Signed-off-by: Luke Marsden <me@lukemarsden.net> Signed-off-by: lukemarsden <me@lukemarsden.net> Signed-off-by: Vikram Vaswani <vikram@dagger.io> Co-authored-by: vikram-dagger <112123850+vikram-dagger@users.noreply.github.com> Co-authored-by: Vikram Vaswani <vikram@dagger.io>
vikram-dagger
added a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
* docs: initial github container registry integration guide Signed-off-by: Luke Marsden <me@lukemarsden.net> * docs: fix link to main.go Signed-off-by: Luke Marsden <me@lukemarsden.net> * docs: hopefully convince linter this isn't a real go file Signed-off-by: Luke Marsden <me@lukemarsden.net> * Update docs/current_docs/integrations/snippets/ghcr-workflow.yml Co-authored-by: vikram-dagger <112123850+vikram-dagger@users.noreply.github.com> Signed-off-by: lukemarsden <me@lukemarsden.net> * Integrates examplein to GitHub Actions integ page Signed-off-by: Vikram Vaswani <vikram@dagger.io> * rename Signed-off-by: Luke Marsden <me@lukemarsden.net> * bump tag Signed-off-by: Luke Marsden <me@lukemarsden.net> --------- Signed-off-by: Luke Marsden <me@lukemarsden.net> Signed-off-by: lukemarsden <me@lukemarsden.net> Signed-off-by: Vikram Vaswani <vikram@dagger.io> Co-authored-by: vikram-dagger <112123850+vikram-dagger@users.noreply.github.com> Co-authored-by: Vikram Vaswani <vikram@dagger.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial guide to how to push to container images into GHCR from Dagger running in GitHub Actions.