ci: mark CVE-2024-3154 as a false scan positive #7215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chadwell <me@jedevc.com>
sipsma
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
(runc is also saying that the advisory is incorrect now too opencontainers/runc#4263)
LGTM
|
Phewww, I genuinely for a moment thought I was going insane 😂 |
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
Signed-off-by: Justin Chadwell <me@jedevc.com>
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
Signed-off-by: Justin Chadwell <me@jedevc.com>
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
Signed-off-by: Justin Chadwell <me@jedevc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feels insane, I'm not quite sure what is going on here. There appear to be 2 separate vulnerability advisories, one in runc and one in cri-o (which doesn't seem to be available yet).
However, this issue definitely doesn't affect us - we don't use cri-o anywhere in our stack, we're not spawning pods in the dagger engine, etc.
There's also not a version of runc we can feasibly upgrade to - 1.2.0-rc1 (as suggested in GHSA-c5pj-mqfh-rvc3), is a minor release, and is also an RC, so we shouldn't depend on it.
We should keep an eye on what the status of these vulnerabilities are, since disclosure still seems ongoing, but we can at least stop CI going red on these.