telemetry: handle more attr type conversions #7259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Suraci <alex@dagger.io>
jedevc
approved these changes
May 2, 2024
| return attribute.StringValue(fmt.Sprintf("UNHANDLED ARRAY ELEM TYPE: %+v (%s)", vals, t)) | ||
| } | ||
| } | ||
| panic("unreachable") |
There was a problem hiding this comment.
Bleh, of course go can't realize this is impossible 😢
kpenfound
pushed a commit
to kpenfound/dagger
that referenced
this pull request
May 2, 2024
Signed-off-by: Alex Suraci <alex@dagger.io> Signed-off-by: kpenfound <kyle@dagger.io>
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
Signed-off-by: Alex Suraci <alex@dagger.io>
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
Signed-off-by: Alex Suraci <alex@dagger.io>
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 3, 2024
Signed-off-by: Alex Suraci <alex@dagger.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a StringSlice for process args, so we actually hit this branch pretty often. Here's a quick and dirty attempt at handling the cases that we can handle.