Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tssdk): expose GraphQL client #7294

Merged
merged 3 commits into from May 7, 2024

Conversation

TomChv
Copy link
Member

@TomChv TomChv commented May 6, 2024

Fixes #7159

Fixes dagger#7159

Signed-off-by: Tom Chauveau <tom@epitech.eu>
@TomChv TomChv requested a review from helderco May 6, 2024 15:24
@TomChv TomChv self-assigned this May 6, 2024
Signed-off-by: Tom Chauveau <tom@epitech.eu>
@TomChv
Copy link
Member Author

TomChv commented May 6, 2024

@helderco Java tests are failing which is not related to our PR, appart from that, everything is good :D

Copy link
Contributor

@helderco helderco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to not have this be async. You'd need to make this simpler, yes, without trying to manage a lazy connection.

@TomChv
Copy link
Member Author

TomChv commented May 7, 2024

Done!

Signed-off-by: Tom Chauveau <tom@epitech.eu>
@TomChv TomChv merged commit 74437a2 into dagger:main May 7, 2024
64 of 65 checks passed
vikram-dagger pushed a commit to vikram-dagger/dagger that referenced this pull request May 8, 2024
Fixes dagger#7159

Signed-off-by: Tom Chauveau <tom@epitech.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Expose GraphQL client in TypeScript SDK
2 participants