Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve releasing during v0.11.3 #7319

Merged
merged 7 commits into from
May 9, 2024

Conversation

jedevc
Copy link
Member

@jedevc jedevc commented May 8, 2024

Signed-off-by: Justin Chadwell me@jedevc.com

@jedevc jedevc requested review from gerhard and matipan May 8, 2024 14:02
@jedevc jedevc marked this pull request as draft May 8, 2024 14:29
@jedevc
Copy link
Member Author

jedevc commented May 8, 2024

Due to #7320, we can't merge this as is - we need to either: run the next release with 0.11.2 (instead of 0.11.3), or modify our Publish/TestPublish functions to now take a list of scalars.

I think it's probably worth adapting to the regression and temporarily disabling the list of scalars for the time being.

@gerhard
Copy link
Member

gerhard commented May 8, 2024

+1 your suggestion @jedevc

I am most interested in checking if the panic in #7192 was addressed in v0.11.3

How difficult would it be to adapt to the regression?

I was also wondering how did the Helm instructions work in practice.

@jedevc jedevc marked this pull request as ready for review May 8, 2024 16:09
@jedevc
Copy link
Member Author

jedevc commented May 8, 2024

I am most interested in checking if the panic in #7192 was addressed in v0.11.3

Yup! I guess we just have to wait to see if it happens 👀

How difficult would it be to adapt to the regression?

Just pushed a commit for it, we can revert it once v0.11.4 releases.

I was also wondering how did the Helm instructions work in practice.

Excellently 🎉 I literally just copy-pasted them, works perfectly ❤️

@gerhard
Copy link
Member

gerhard commented May 8, 2024

Before we merge this, I would like to add some more details for the dagger-for-github release so that we have a quick fix for what @jpadams was mentioning earlier today. Taking that action item on as I review & merge this.

Copy link
Member

@gerhard gerhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now looks good to me!

OK to merge when all checks pass 👍 🚀

jedevc and others added 7 commits May 9, 2024 10:36
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
@jedevc jedevc force-pushed the improve-releasing-during-v0.11.3 branch from 9ca7294 to 4cd1863 Compare May 9, 2024 09:38
@jedevc jedevc merged commit 2a4885e into dagger:main May 9, 2024
61 checks passed
@jedevc jedevc deleted the improve-releasing-during-v0.11.3 branch May 9, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants