docs: Add multi-lang name overrides page #7429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
vikram-dagger
force-pushed
the
docs-263-aliases-name-overrides
branch
from
6beee28
to
43aac09
Compare
vikram-dagger
commented
May 21, 2024
| @@ -0,0 +1,33 @@ | |||
| import { dag, Container, object, func, field } from "@dagger.io/dagger" | |||
There was a problem hiding this comment.
@TomChv please review this code
vikram-dagger
commented
May 21, 2024
| @object() | ||
| class MyModule { | ||
| /** | ||
| * Definition |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes because in one case, def_ is a field, in the other he's an argument of the constructor.
It's 2 different things
There was a problem hiding this comment.
Sorry, I still didn't understand this. Are the TypeScript and Python snippets equivalent?
- If yes, then why is the additional inline doc required in the TypeScript code?
- Or if not, can you please suggest code changes inline to make them equivalent?
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
|
We should not document this. It's not clear that it's a good pattern. Let's remove instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.