Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix powershell install script to work when on a different drive #7445

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

angrybat
Copy link
Contributor

Changed the default install path from $env:HOMEPATH to $env:USERPROFILE as this includes the drive. Currently when calling the install script on the D: drive the transfer from the temp directory to the install path fails. This is not reported as an error and the install script appears to have worked correctly. This is because $env:HOMEPATH does not include the drive in the path. Changing this to $env:USERPROFILE has the same path but the path includes the drive, this fixes the issue.

@jedevc
Copy link
Member

jedevc commented May 23, 2024

@angrybat can you add a DCO sign-off to your commit? See the instructions in https://github.com/dagger/dagger/pull/7445/checks?check_run_id=25300211561.

@jedevc
Copy link
Member

jedevc commented May 23, 2024

LGTM to me once DCO is added, looks like USERDRIVE is the generally preferred variable to use instead of HOMEPATH these days as well.

Thanks! 🎉

@angrybat
Copy link
Contributor Author

@jedevc Hopefully I have signed the commit now. Sorry for the delay but I am happy to help where I can 😄

@jedevc
Copy link
Member

jedevc commented May 28, 2024

@angrybat it looks like it's still not done, sorry! Essentially, you should just need to run git commit --amend -s on this branch.

Otherwise, I can manually sign it off for you, if you agree with that.

Sorry for the delay, thanks again for this PR, we just need to have the sign-offs so we can ensure that we actually have permission to use all the contributed code in this project.

Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

… the drive

Signed-off-by: angrybat <jasonmoore95@hotmail.com>
@jedevc
Copy link
Member

jedevc commented Jun 12, 2024

Rebased.

I've also signed off the commit so we can bring this in, since @angrybat attempted to here: #7445 (comment):

@jedevc Hopefully I have signed the commit now. Sorry for the delay but I am happy to help where I can 😄

@jedevc jedevc merged commit 173761f into dagger:main Jun 12, 2024
105 checks passed
@gerhard gerhard added this to the v0.11.8 milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants