-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update ts docs field to @func
#7714
base: main
Are you sure you want to change the base?
Conversation
Follows up dagger#7701 with a doc update Signed-off-by: Tom Chauveau <tom@epitech.eu>
Signed-off-by: Tom Chauveau <tom@epitech.eu>
Signed-off-by: Tom Chauveau <tom@epitech.eu>
ae54c8a
to
316fc1e
Compare
@@ -1,11 +1,11 @@ | |||
import { dag, Container, object, func, field } from "@dagger.io/dagger" | |||
import { object, func } from "@dagger.io/dagger" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was dag
& Container
redundant here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that one comment, everything else looks good to me. WDYT @helderco ?
This should only be merged after #7701 is released. By that time there could be more doc snippets to update. That's why I'm holding off review until then. |
Follows up #7701 with a doc update