Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update ts docs field to @func #7714

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TomChv
Copy link
Member

@TomChv TomChv commented Jun 20, 2024

Follows up #7701 with a doc update

@TomChv TomChv self-assigned this Jun 20, 2024
Tom Chauveau added 3 commits June 21, 2024 18:02
Follows up dagger#7701 with a doc update

Signed-off-by: Tom Chauveau <tom@epitech.eu>
Signed-off-by: Tom Chauveau <tom@epitech.eu>
Signed-off-by: Tom Chauveau <tom@epitech.eu>
@TomChv TomChv force-pushed the docs/update-ts-field-deprecation branch from ae54c8a to 316fc1e Compare June 21, 2024 16:02
@@ -1,11 +1,11 @@
import { dag, Container, object, func, field } from "@dagger.io/dagger"
import { object, func } from "@dagger.io/dagger"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was dag & Container redundant here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not used.

Copy link
Member

@gerhard gerhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that one comment, everything else looks good to me. WDYT @helderco ?

@helderco
Copy link
Contributor

This should only be merged after #7701 is released. By that time there could be more doc snippets to update. That's why I'm holding off review until then.

@gerhard gerhard added this to the v0.12.1 milestone Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants