fix: dagger develop generate license only if --sdk is set #7719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomChv
changed the title
helderco
reviewed
Jun 21, 2024
helderco
reviewed
Jun 24, 2024
TomChv
force-pushed
the
fix/license-generation-on-develop
branch
from
29bfb66
to
84786ca
Compare
Fixes 7703 It will be followed up by dagger#7715 after discussion Signed-off-by: Tom Chauveau <tom@epitech.eu>
Signed-off-by: Tom Chauveau <tom@epitech.eu>
Signed-off-by: Tom Chauveau <tom@epitech.eu>
Signed-off-by: Tom Chauveau <tom@epitech.eu>
Signed-off-by: Tom Chauveau <tom@epitech.eu>
Signed-off-by: Tom Chauveau <tom@epitech.eu>
So it'll get created even if provided license ID is the same as the default. Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
helderco
force-pushed
the
fix/license-generation-on-develop
branch
from
81dc673
to
c52c84c
Compare
jedevc
approved these changes
Jun 25, 2024
|
Test fail fluke. Re-ran the action in GH, which turned green, but corresponding dagger cloud trace stayed the same. Good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
LICENSEwill only be generated now if--sdkis set ondagger develop, like indagger init. It's also possible to explictly disable creating a license by providing an empty--license=.Fixes #7703
It will be followed up by #7715 after discussion