Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use for-keys instead of while-each #25

Closed
wants to merge 1 commit into from

Conversation

Grinnz
Copy link

@Grinnz Grinnz commented Oct 6, 2016

I am not sure if there is a performance reason to use each here, but otherwise, a for loop works just as well with less baggage.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.485% when pulling 6e4710b on Grinnz:dont_use_each into e19ae20 on dagolden:master.

@xdg
Copy link
Contributor

xdg commented Oct 6, 2016

For working code, I generally don't accept changes for personal style preferences. If there's a bug or a significant compelling reason otherwise, feel free to reopen this.

@xdg xdg closed this Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants