Only match ASCII digits in from_string() method. #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code currently works:
But it spits out warnings when you try to print it via
as_string()
because\d
in regexes matches more than just ASCII digits. The following test program shows the problem:The pull request substitutes
[0-9]
for\d
in thefrom_string()
regex (thus being compatible with older Perls) to fix this issue. There is a test to verify the expected exception.