Support IO::Socket::SSL:PublicSuffix #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the prevalence of https on today's Internet, many users will already have this module installed as part of IO::Socket::SSL. Mozilla::PublicSuffix hasn't been updated in several years, but it makes sense to keep it as a "better than nothing" option.
The preceding commit enables IO::Socket::SSL::PublicSuffix for checking public suffixes in preference to Mozilla::PublicSuffix. Test that the code works with either.
|
Hi, Tom. I don't want to pick sides in the battle over suffix lists, and I'm very reluctant to recommend a modules that requires SSL support. I'm not going to accept this PR but I'll open a separate issue about more flexible suffix support. |
|
Thanks for your review. I understand your decision and will be happy to review or discuss any alternative approach if that would help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.