Depend only on necessary d3 modules #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lutzroeder, so apparently I deleted the fork I originally made this PR from. As a result I don't think I can resolve the conflicts. However, I think you should have write access to this PR so if you're still interested in merging, then you could make the necessary changes for merging. |
|
I ported the project to es6 and I accept contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
dagre-d3depends on the entired3library, but it only directly uses exports from thed3-selectionandd3-shapelibraries. You can verify this by searching for "d3" in this repository and scoping to JavaScript files. The code usesd3.select, which belongs to thed3-selectionlibrary, andd3.curveLinear, which belongs to thed3-shapelibrary.This PR replaces
dagre-d3'sd3dependency with thed3-selectionandd3-shapedependencies, and as a result nearly halves the size ofdagre-d3.min.js(from 708kB to 367kB).