Fix unable to layout compound graph #429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rustedgrail and anyone in the support team of this project, please help me by reviewing this PR. I'm currently working on the project and have also come across this issue. Many thanks! |
|
I've updated the PR with recent changes and resolving the package-lock.json. Since the tests are still failing, I can't merge it, but if you want to take a look I can merge the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #236
It is currently impossible to layout a graph having an edge between a compound element and a simple one.
The error
Cannot set property ‘rank’ of undefinedoccurs and breaks the layout process.It can't be merged as is as it doesn't pass the tests, anyone should feel free to correct it, but it allows to run the layout.