Skip to content

Commit

Permalink
Update CONTRIBUTING.md (#177)
Browse files Browse the repository at this point in the history
  • Loading branch information
maximearmstrong committed May 9, 2024
1 parent cd2a864 commit 71ea967
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,7 @@ __pycache__/
src/pex-builder/build

# locally built wheels for Dockerfile.dagster-manylinux-builder
wheels/*whl
wheels/*whl

# PyCharm IDE Config files
.idea/
6 changes: 4 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Steps to release

**Note**: These steps can also be used to release a docker-cloud-action image to test your changes.

## Step 1. Log into docker ghcr.io

See [authenticate to GHCR with a PAT](https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry).
Expand Down Expand Up @@ -42,7 +44,7 @@ The point version is the next unused `v0.1.*` version, eg `v0.1.22` above. Creat

## Step 3. Build and deploy a new docker-cloud-action image, a new dagster.cloud.pex and update code references to docker

A script does this work:
A script does this work. **Note**: a virtual environment using Python3.8 is required to run the script.

```
# Note no 'v' prefix
Expand All @@ -51,7 +53,7 @@ A script does this work:
```

This leaves uncommited changes in the working directory.
This leaves uncommitted changes in the working directory.

# Commit and tag the new version

Expand Down

0 comments on commit 71ea967

Please sign in to comment.