fix: resolve correct legacy arguments for emr pyspark step launcher (#…

…12419)

### Summary & Motivation
Compare `deploy_local_job_package` with `deploy_local_pipeline_package`,
as intended.

### How I Tested These Changes
pytest

python_modules/libraries/dagster-aws/dagster_aws/emr/pyspark_step_launcher.py

@@ -169,7 +169,7 @@ def emr_pyspark_step_launcher(context):
     ) or context.resource_config.get("local_pipeline_package_path")
 
     if context.resource_config.get("deploy_local_job_package") and context.resource_config.get(
-        "deploy_local_job_package"
+        "deploy_local_pipeline_package"
     ):
         raise DagsterInvariantViolationError(
             "Provided both ``deploy_local_job_package`` and legacy version "

python_modules/libraries/dagster-aws/dagster_aws_tests/emr_tests/test_pyspark_step_launcher.py

@@ -1,8 +1,10 @@
+import os
 from unittest import mock
 
-from dagster import DagsterEvent, EventLogEntry
+import pytest
+from dagster import DagsterEvent, EventLogEntry, build_init_resource_context
 from dagster._core.execution.plan.objects import StepSuccessData
-from dagster_aws.emr.pyspark_step_launcher import EmrPySparkStepLauncher
+from dagster_aws.emr.pyspark_step_launcher import EmrPySparkStepLauncher, emr_pyspark_step_launcher
 
 EVENTS = [
     EventLogEntry(
@@ -59,3 +61,53 @@ def test_wait_for_completion(_mock_is_emr_step_complete, _mock_read_events):
         launcher.wait_for_completion(mock.MagicMock(), None, None, None, None, check_interval=0)
     )
     assert yielded_events == [event.dagster_event for event in EVENTS if event.is_dagster_event]
+
+
+def test_emr_pyspark_step_launcher_legacy_arguments():
+    mock_config = {
+        "local_job_package_path": os.path.abspath(os.path.dirname(__file__)),
+        "cluster_id": "123",
+        "staging_bucket": "bucket",
+        "region_name": "us-west-1",
+    }
+
+    with pytest.raises(Exception):
+        emr_pyspark_step_launcher(
+            build_init_resource_context(
+                config={
+                    **mock_config,
+                    "local_pipeline_package_path": "path",
+                }
+            )
+        )
+
+    with pytest.raises(Exception):
+        emr_pyspark_step_launcher(
+            build_init_resource_context(
+                config={
+                    **mock_config,
+                    "deploy_local_job_package": True,
+                    "deploy_local_pipeline_package": True,
+                }
+            )
+        )
+
+    with pytest.raises(Exception):
+        emr_pyspark_step_launcher(
+            build_init_resource_context(
+                config={
+                    **mock_config,
+                    "s3_job_package_path": "path",
+                    "s3_pipeline_package_path": "path",
+                }
+            )
+        )
+
+    assert emr_pyspark_step_launcher(
+        build_init_resource_context(
+            config={
+                **mock_config,
+                "deploy_local_job_package": True,
+            }
+        )
+    )