Skip to content

Commit

Permalink
[dagit] Move yarn analyze to packages/app (#7523)
Browse files Browse the repository at this point in the history
## Summary

The `yarn analyze` script is on `core`, which no longer produces its own build. It should be on `app`.

## Test Plan

Run `yarn build`, then `yarn analyze` in `packages/app`. Verify that it produces a bundle analysis page.
  • Loading branch information
hellendag committed Apr 21, 2022
1 parent fc57d23 commit 078d828
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 3 additions & 1 deletion js_modules/dagit/packages/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,16 @@
"eslint": "8.7.0",
"eslint-webpack-plugin": "3.1.1",
"prettier": "2.2.1",
"source-map-explorer": "^2.5.0",
"typescript": "^4.5.4"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"lint": "eslint src/ --ext=.tsx,.ts,.js --fix -c .eslintrc.js",
"test": "react-scripts test",
"ts": "tsc -p ."
"ts": "tsc -p .",
"analyze": "source-map-explorer 'build/static/js/*.js'"
},
"browserslist": {
"production": [
Expand Down
4 changes: 1 addition & 3 deletions js_modules/dagit/packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
"generate-graphql": "ts-node -O '{\"module\": \"commonjs\"}' ./src/scripts/generateGraphQLTypes.ts",
"generate-perms": "ts-node -O '{\"module\": \"commonjs\"}' ./src/scripts/generatePermissions.ts",
"storybook": "start-storybook -p 6006",
"build-storybook": "build-storybook",
"analyze": "source-map-explorer 'build/static/js/*.js'"
"build-storybook": "build-storybook"
},
"peerDependencies": {
"@apollo/client": "3.3.16",
Expand Down Expand Up @@ -132,7 +131,6 @@
"react-router": "^5.2.1",
"react-router-dom": "^5.3.0",
"rgb-hex": "^4.0.0",
"source-map-explorer": "^2.5.0",
"styled-components": "^5.3.3",
"ts-node": "9.1.1",
"ts-prune": "0.8.9",
Expand Down
2 changes: 1 addition & 1 deletion js_modules/dagit/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5023,6 +5023,7 @@ __metadata:
react-dom: ^17.0.2
react-router: ^5.2.1
react-router-dom: ^5.3.0
source-map-explorer: ^2.5.0
typescript: ^4.5.4
web-vitals: ^2.1.3
languageName: unknown
Expand Down Expand Up @@ -5128,7 +5129,6 @@ __metadata:
remark-gfm: 1.0.0
remark-plain-text: ^0.2.0
rgb-hex: ^4.0.0
source-map-explorer: ^2.5.0
styled-components: ^5.3.3
subscriptions-transport-ws: ^0.9.15
ts-node: 9.1.1
Expand Down

0 comments on commit 078d828

Please sign in to comment.