fix(helm): use templated comment (#8137)

dagster-io · May 31, 2022 · 0d4dd5a · 0d4dd5a
1 parent 9af83ae
commit 0d4dd5a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.buildkite/dagster-buildkite/dagster_buildkite/steps/helm.py b/.buildkite/dagster-buildkite/dagster_buildkite/steps/helm.py
@@ -12,6 +12,12 @@ def build_helm_steps() -> List[BuildkiteStep]:
     steps += _build_lint_steps()
     schema_group = PackageSpec(
         os.path.join("helm", "dagster", "schema"),
+        unsupported_python_versions=[
+            # run helm schema tests only once, on the latest python version
+            AvailablePythonVersion.V3_6,
+            AvailablePythonVersion.V3_7,
+            AvailablePythonVersion.V3_8,
+        ],
         name="dagster-helm-schema",
         upload_coverage=False,
         retries=2,

diff --git a/helm/dagster/charts/dagster-user-deployments/templates/helpers/_helpers.tpl b/helm/dagster/charts/dagster-user-deployments/templates/helpers/_helpers.tpl
@@ -32,7 +32,7 @@ If release name contains chart name it will be used as a full name.
   {{- $ := index . 0 }}
 
   {{- with index . 1 }}
-    # Filter the tag to parse strings, string integers, and string floats.
+    {{- /* Filter the tag to parse strings, string integers, and string floats. */}}
     {{- $tag := .tag | default $.Chart.Version | toYaml | trimAll "\"" }}
     {{- printf "%s:%s" .repository $tag }}
   {{- end }}

diff --git a/helm/dagster/templates/helpers/_helpers.tpl b/helm/dagster/templates/helpers/_helpers.tpl
@@ -33,7 +33,7 @@ If release name contains chart name it will be used as a full name.
   {{- $ := index . 0 }}
 
   {{- with index . 1 }}
-    # Filter the tag to parse strings, string integers, and string floats.
+    {{- /* Filter the tag to parse strings, string integers, and string floats. */}}
     {{- $tag := .tag | default $.Chart.Version | toYaml | trimAll "\"" }}
     {{- printf "%s:%s" .repository $tag }}
   {{- end }}