chore(helm): remove local from compute log manager options (#7924)

dagster-io · May 17, 2022 · 17fa439 · 17fa439
1 parent 06149b6
commit 17fa439
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 13 deletions.
diff --git a/helm/dagster/schema/schema/charts/dagster/subschema/compute_log_manager.py b/helm/dagster/schema/schema/charts/dagster/subschema/compute_log_manager.py
@@ -9,7 +9,6 @@
 
 class ComputeLogManagerType(str, Enum):
     NOOP = "NoOpComputeLogManager"
-    LOCAL = "LocalComputeLogManager"  # deprecated in favor of noop
     AZURE = "AzureBlobComputeLogManager"
     GCS = "GCSComputeLogManager"
     S3 = "S3ComputeLogManager"

diff --git a/helm/dagster/schema/schema_tests/test_instance.py b/helm/dagster/schema/schema_tests/test_instance.py
@@ -414,16 +414,9 @@ def test_custom_run_coordinator_config(template: HelmTemplate):
     assert instance["run_coordinator"]["config"] == config
 
 
-@pytest.mark.parametrize(
-    "compute_log_manager_type",
-    [ComputeLogManagerType.NOOP, ComputeLogManagerType.LOCAL],
-    ids=["noop", "local compute log manager becomes noop"],
-)
-def test_noop_compute_log_manager(
-    template: HelmTemplate, compute_log_manager_type: ComputeLogManagerType
-):
+def test_noop_compute_log_manager(template: HelmTemplate):
     helm_values = DagsterHelmValues.construct(
-        computeLogManager=ComputeLogManager.construct(type=compute_log_manager_type)
+        computeLogManager=ComputeLogManager.construct(type=ComputeLogManagerType.NOOP)
     )
 
     configmaps = template.render(helm_values)

diff --git a/helm/dagster/templates/configmap-instance.yaml b/helm/dagster/templates/configmap-instance.yaml
@@ -80,7 +80,7 @@ data:
 
     {{- $computeLogManagerType := .Values.computeLogManager.type }}
     compute_logs:
-      {{- if has $computeLogManagerType (list "NoOpComputeLogManager" "LocalComputeLogManager") -}}
+      {{- if eq $computeLogManagerType "NoOpComputeLogManager" -}}
         {{- include "dagsterYaml.computeLogManager.noop" . | indent 6 -}}
       {{- else if eq $computeLogManagerType "AzureBlobComputeLogManager" }}
         {{- include "dagsterYaml.computeLogManager.azure" . | indent 6 -}}

diff --git a/helm/dagster/values.schema.json b/helm/dagster/values.schema.json
diff --git a/helm/dagster/values.yaml b/helm/dagster/values.yaml
@@ -160,7 +160,6 @@ dagit:
 computeLogManager:
   # Type can be one of [
   #   NoOpComputeLogManager,
-  #   LocalComputeLogManager (deprecated - if set, NoOpComputeLogManager will be used instead),
   #   AzureBlobComputeLogManager,
   #   GCSComputeLogManager,
   #   S3ComputeLogManager,