Fix celery docker executor failing on None metadata (#7330)

dagster-io · Apr 6, 2022 · 1860b3a · 1860b3a
1 parent 2e900d5
commit 1860b3a
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/python_modules/libraries/dagster-celery-docker/dagster_celery_docker/executor.py b/python_modules/libraries/dagster-celery-docker/dagster_celery_docker/executor.py
@@ -285,15 +285,14 @@ def _execute_step_docker(
 
             res = docker_response.decode("utf-8")
         except docker.errors.ContainerError as err:
+            entries = [MetadataEntry("Job image", value=docker_image)]
+            if err.stderr is not None:
+                entries.append(MetadataEntry("Docker stderr", value=err.stderr))
+
             instance.report_engine_event(
                 "Failed to run steps {} in Docker container {}".format(step_keys_str, docker_image),
                 pipeline_run,
-                EngineEventData(
-                    [
-                        MetadataEntry("Job image", value=docker_image),
-                        MetadataEntry("Docker stderr", value=err.stderr),
-                    ],
-                ),
+                EngineEventData(entries),
                 CeleryDockerExecutor,
                 step_key=execute_step_args.step_keys_to_execute[0],
             )