Sort backfill runs by start time

dagster-io · Jul 1, 2024 · 1a82012 · 1a82012
1 parent bb69f3f
commit 1a82012
Show file tree

Hide file tree

Showing 26 changed files with 43 additions and 8 deletions.
diff --git a/...ages/ui-core/src/assets/AutoMaterializePolicyPage/types/AutomaterializeRunsTable.types.ts b/...ages/ui-core/src/assets/AutoMaterializePolicyPage/types/AutomaterializeRunsTable.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/gantt/types/RunGroupPanel.types.ts b/js_modules/dagster-ui/packages/ui-core/src/gantt/types/RunGroupPanel.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/graphql/schema.graphql b/js_modules/dagster-ui/packages/ui-core/src/graphql/schema.graphql
diff --git a/js_modules/dagster-ui/packages/ui-core/src/graphql/types.ts b/js_modules/dagster-ui/packages/ui-core/src/graphql/types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/instigation/types/InstigationTick.types.ts b/js_modules/dagster-ui/packages/ui-core/src/instigation/types/InstigationTick.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/instigation/types/InstigationUtils.types.ts b/js_modules/dagster-ui/packages/ui-core/src/instigation/types/InstigationUtils.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/nav/types/JobMetadata.types.ts b/js_modules/dagster-ui/packages/ui-core/src/nav/types/JobMetadata.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/nav/types/LatestRunTag.types.ts b/js_modules/dagster-ui/packages/ui-core/src/nav/types/LatestRunTag.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/partitions/types/PartitionRunList.types.ts b/js_modules/dagster-ui/packages/ui-core/src/partitions/types/PartitionRunList.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/pipelines/types/PipelineRunsRoot.types.ts b/js_modules/dagster-ui/packages/ui-core/src/pipelines/types/PipelineRunsRoot.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/RunUtils.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/RunUtils.tsx
@@ -290,15 +290,11 @@ interface RunTimeProps {
 }
 
 export const RunTime = memo(({run}: RunTimeProps) => {
-  const {startTime, updateTime} = run;
+  const {creationTime} = run;
 
   return (
     <div>
-      {startTime ? (
-        <Timestamp timestamp={{unix: startTime}} />
-      ) : updateTime ? (
-        <Timestamp timestamp={{unix: updateTime}} />
-      ) : null}
+      <Timestamp timestamp={{unix: creationTime}} />
     </div>
   );
 });
@@ -328,6 +324,7 @@ export const RUN_TIME_FRAGMENT = gql`
   fragment RunTimeFragment on Run {
     id
     status
+    creationTime
     startTime
     endTime
     updateTime

diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/__stories__/RunStatusPez.stories.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/__stories__/RunStatusPez.stories.tsx
@@ -50,14 +50,14 @@ export const List = () => {
       id: string;
       status: RunStatus;
       startTime: number;
+      creationTime: number;
       endTime: number;
     }[],
   ): RunTimeFragment[] =>
     inp.map((r) => ({...r, runId: r.id, updateTime: null, __typename: 'Run'}));
 
   const fakeRepo = 'a_repo.py';
   const fakeId = useCallback(() => faker.datatype.uuid(), []);
-
   return (
     <StorybookProvider apolloProps={{mocks}}>
       <Box flex={{direction: 'column', gap: 8}}>
@@ -87,6 +87,7 @@ export const List = () => {
                   id,
                   runId: id,
                   status: RunStatus.STARTING,
+                  creationTime: Date.now() - (idx + 1) * 60 * 60 * 1000,
                   startTime: Date.now() - (idx + 1) * 60 * 60 * 1000,
                   endTime: Date.now() - idx * 60 * 60 * 1000,
                   updateTime: null,

diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunTable.types.ts b/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunTable.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunUtils.types.ts b/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunUtils.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunsRoot.types.ts b/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunsRoot.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/types/useRunsForTimeline.types.ts b/js_modules/dagster-ui/packages/ui-core/src/runs/types/useRunsForTimeline.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/schedules/types/ScheduleRoot.types.ts b/js_modules/dagster-ui/packages/ui-core/src/schedules/types/ScheduleRoot.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/schedules/types/ScheduleUtils.types.ts b/js_modules/dagster-ui/packages/ui-core/src/schedules/types/ScheduleUtils.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/sensors/types/SensorFragment.types.ts b/js_modules/dagster-ui/packages/ui-core/src/sensors/types/SensorFragment.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/sensors/types/SensorPreviousRuns.types.ts b/js_modules/dagster-ui/packages/ui-core/src/sensors/types/SensorPreviousRuns.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/sensors/types/SensorRoot.types.ts b/js_modules/dagster-ui/packages/ui-core/src/sensors/types/SensorRoot.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/testing/generateRunMocks.ts b/js_modules/dagster-ui/packages/ui-core/src/testing/generateRunMocks.ts
@@ -14,10 +14,12 @@ export const generateRunMocks = (runCount: number, range: [number, number]) => {
           ? RunStatus.STARTED
           : faker.random.arrayElement([RunStatus.SUCCESS, RunStatus.FAILURE]);
 
+      const startTime = startDate.getTime();
       return {
         id: faker.datatype.uuid(),
+        startTime: startTime,
+        creationTime: startTime,
         status,
-        startTime: startDate.getTime(),
         endTime,
       };
     });

diff --git a/js_modules/dagster-ui/packages/ui-core/src/workspace/types/VirtualizedJobRow.types.ts b/js_modules/dagster-ui/packages/ui-core/src/workspace/types/VirtualizedJobRow.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/workspace/types/VirtualizedScheduleRow.types.ts b/js_modules/dagster-ui/packages/ui-core/src/workspace/types/VirtualizedScheduleRow.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/workspace/types/VirtualizedSensorRow.types.ts b/js_modules/dagster-ui/packages/ui-core/src/workspace/types/VirtualizedSensorRow.types.ts
diff --git a/python_modules/dagster-graphql/dagster_graphql/schema/pipelines/pipeline.py b/python_modules/dagster-graphql/dagster_graphql/schema/pipelines/pipeline.py
@@ -365,6 +365,7 @@ class GrapheneRun(graphene.ObjectType):
         graphene.NonNull(GrapheneEventConnection),
         afterCursor=graphene.Argument(graphene.String),
     )
+    creationTime = graphene.NonNull(graphene.Float)
     startTime = graphene.Float()
     endTime = graphene.Float()
     updateTime = graphene.Float()
@@ -586,6 +587,10 @@ def resolve_updateTime(self, graphene_info: ResolveInfo):
         run_record = self._get_run_record(graphene_info.context.instance)
         return datetime_as_float(run_record.update_timestamp)
 
+    def resolve_creationTime(self, graphene_info: ResolveInfo):
+        run_record = self._get_run_record(graphene_info.context.instance)
+        return datetime_as_float(run_record.create_timestamp)
+
     def resolve_hasConcurrencyKeySlots(self, graphene_info: ResolveInfo):
         instance = graphene_info.context.instance
         if not instance.event_log_storage.supports_global_concurrency_limits: