fix perms in dagit (#7115)

* fix perms in dagit * add changes
dagster-io · Mar 17, 2022 · 1c7f030 · 1c7f030 · vercel · Mar 17, 2022
1 parent 0c72a16
commit 1c7f030
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,5 +1,10 @@
 # Changelog
 
+# 0.14.5
+### Bugfixes
+
+- [dagit] Fixed issue where sensors could not be turned on/off in dagit.
+
 # 0.14.4
 ### New
 

diff --git a/js_modules/dagit/packages/core/src/app/Permissions.tsx b/js_modules/dagit/packages/core/src/app/Permissions.tsx
@@ -9,8 +9,7 @@ export type PermissionsFromJSON = {
   launch_pipeline_reexecution?: boolean;
   start_schedule?: boolean;
   stop_running_schedule?: boolean;
-  start_sensor?: boolean;
-  stop_sensor?: boolean;
+  edit_sensor?: boolean;
   terminate_pipeline_execution?: boolean;
   delete_pipeline_run?: boolean;
   reload_repository_location?: boolean;
@@ -31,8 +30,8 @@ const extractPermissions = (permissions: PermissionFragment[]) => {
     canLaunchPipelineReexecution: !!permsMap.launch_pipeline_reexecution,
     canStartSchedule: !!permsMap.start_schedule,
     canStopRunningSchedule: !!permsMap.stop_running_schedule,
-    canStartSensor: !!permsMap.start_sensor,
-    canStopSensor: !!permsMap.stop_sensor,
+    canStartSensor: !!permsMap.edit_sensor,
+    canStopSensor: !!permsMap.edit_sensor,
     canTerminatePipelineExecution: !!permsMap.terminate_pipeline_execution,
     canDeletePipelineRun: !!permsMap.delete_pipeline_run,
     canReloadRepositoryLocation: !!permsMap.reload_repository_location,

diff --git a/js_modules/dagit/packages/core/src/testing/TestProvider.tsx b/js_modules/dagit/packages/core/src/testing/TestProvider.tsx
@@ -17,8 +17,7 @@ export const PERMISSIONS_ALLOW_ALL: PermissionsFromJSON = {
   launch_pipeline_reexecution: true,
   start_schedule: true,
   stop_running_schedule: true,
-  start_sensor: true,
-  stop_sensor: true,
+  edit_sensor: true,
   terminate_pipeline_execution: true,
   delete_pipeline_run: true,
   reload_repository_location: true,